Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing in things by object rather than by ID. #6

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

oxinabox
Copy link
Owner

Basically under this change anytime we need an ID,
if we were not passed in a string we try to read the an id field from whatever we were passed.

This is convient because can use whole objects as are returned.
Like

board=create_board(cred, ...)
list = create_list(cred, board)

rather than having to do:

board=create_board(cred, ...)
list = create_list(cred, board.id,...)

This takes out friction and makes it easier to chain operations

@codecov-io
Copy link

codecov-io commented May 10, 2020

Codecov Report

Merging #6 into master will decrease coverage by 4.19%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   93.93%   89.74%   -4.20%     
==========================================
  Files           4        4              
  Lines          33       39       +6     
==========================================
+ Hits           31       35       +4     
- Misses          2        4       +2     
Impacted Files Coverage Δ
src/api.jl 90.00% <71.42%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abbe3f...19cb0d1. Read the comment docs.

@oxinabox
Copy link
Owner Author

Should fix that missed coverage

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #6 into master will increase coverage by 0.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   93.93%   94.87%   +0.93%     
==========================================
  Files           4        4              
  Lines          33       39       +6     
==========================================
+ Hits           31       37       +6     
  Misses          2        2              
Impacted Files Coverage Δ
src/api.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abbe3f...4e97400. Read the comment docs.

@oxinabox oxinabox merged commit 1c88fba into master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants