Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification #2

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Classification #2

wants to merge 46 commits into from

Conversation

clabas
Copy link

@clabas clabas commented Dec 19, 2016

This pull request adds support for dynamically setting classification banners based on an overall system classification. Per Igor, despite this technically being a breaking change, making this effort available to the community.

Note that this contains the changes added in the 'cas' branch.

rkenyon1969 and others added 30 commits September 7, 2016 11:12
Fix(Tour): Modified Search Step and added code to support Tour in Hud
fix(index):added a check to see if we should display webtop
fix(reviews): Changed variable name and text to reflect that reviews …
fix(Carousel): Fixed arrows disappearing when tabbing into carousel #524
enhance(tags): Increase tag length to 30 #719
Fix(SecurityBanner): display different banner for second party users
Fix(Carousel): Moved carousel buttons below carousel div to correct c…
fix(notificationSettings) Fix notification overflow #691
@mparizernc
Copy link

@clabas we appreciate your pull request and would like to put it forward for our GOSS Board to determine if this should be included in the product. We have just formalized our patch process that can be found at https://ozone.nextcentury.com/patch_process. Please ensure that the following has been included so that it can be presented to the board:

  • Add comments in the code to provide detailed developer-level documentation of your changes
  • Verify that the entire code base builds without issue after all changes are made
  • Document and provide unit/regression tests that verify that your new code functions and can be tested by others
  • Submit complete and adequate documentation with the pull request explaining the feature(s) and how it works

Please be sure to include in your documentation how this will be a breaking change.

Thank you again for your contribution to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants