Jack Chester Solutions #81
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Jun 16, 2017
| @@ -1,5 +1,7 @@ | |||
| # Implement this in such a way that when called below, detect_anagram will result in true or false. | |||
| def canonical(word) | |||
| word = word.upcase | |||
| word.split("").sort.to_s #split into characters, sort alphabetically, push back into one string. | |||
There was a problem hiding this comment.
String#chars is a bit simpler way to split a string into characters.
There was a problem hiding this comment.
Is that to_s at the end giving you back the string you think it is? Do we even need this method to return a string?
There was a problem hiding this comment.
Ah, each character is individually being converted to a string. Array#join would have been better, although looking back I didn't even need to join the string at all to determine whether or not it was an anagram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo @matt529