-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] feat(Card): new "selected" prop #6444
Conversation
CPerinet
commented
Oct 6, 2023
•
edited
Loading
edited
Selected propBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Selected Control cardsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
SwitchCard example looks pretty good: I think you need to make some fixes for CardList > SwitchCard, though: Also, are there any cases when we'd want to disable this selected styling when a SwitchCard is checked? If so, could we add a prop to disable it, something like |
Add showAsSelectedWhenChecked propBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Skip cacheBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix dark theme, add option to ControlCardListExampleBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix core:test:typeCheckBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
This PR is most of the way there, but we need to think through how the new props |
Ok, it seems like these names will work fine with RadioCard and CheckboxCard. Both Radio and Checkbox have the |