fix(Popover): a11y aria props applied to child target, not wrapper #6604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-expanded
andaria-haspopover
should be applied to the interactive element, which is the passed child target, not the span wrapper. Compared to the span wrapper, the child element is the interactive element because A) it is likely to be an interactive element such as a<Button>
and B) it's what gets thetabIndex
prop.