-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
router with strict_slashes disabled doesn't match URL without slash #2482
Comments
Duplicate of #2478. Please reopen if you disagree. |
I might possibly agree that #2478 could be a bug report of the same issue ... Correct me if I'm wrong, but the resolution of #2478 appears to be that the behavior WAS wrong before and has been FIXED in #1074? And all that was needed was to just update the change log to reflect an intentional change/fix in behavior? The reporter in #2478 seems to be okay with simply updating the change log, but I'm not sure if I agree. IMO, EITHER of the following should resolve to the same route (currently the latter is treated as if Reported in #2467:
Being reported here #2482 (and I guess also possibly here #2478):
|
I see. I think #2487 is the solution to these issues. There are really three options people expect. |
Under v2.1.0 and earlier,
strict_slashes=False
could be used to make a routing rule for/foo/
match/foo
as well.This appears to have changed in 2.2.0. (NOTE: opposite of what was reported in bug report -> #2467)
Example flask app:
... And then flask run and curl localhost:5000/foo. Under v2.1.0 you should see hi, but under 2.2.0, a 404.
My app currently sets strict_slashes = False and all routes are returning a 404.
Environment:
The text was updated successfully, but these errors were encountered: