Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL routing test that fails currently. #186

Closed
wants to merge 86 commits into from
Closed

URL routing test that fails currently. #186

wants to merge 86 commits into from

Conversation

jace
Copy link
Contributor

@jace jace commented May 8, 2012

As described in issue #185.

mitsuhiko and others added 30 commits September 29, 2011 23:35
@mitsuhiko
Removed undocumented attribute
0f705da
@mitsuhiko
Removed dead reference
409ed22
@mitsuhiko
Merge branch '0.8-maintenance'
c0999e7
@mitsuhiko
Merge branch '0.8-maintenance'
8e4fdae
@mitsuhiko
Merge branch '0.8-maintenance'
f6a0f63
@mitsuhiko
Merge commit 'eb96c05'
aa76943
@mitsuhiko
Added support for tell() on the stream.
639f35b
@mitsuhiko
Moved a few generic asserts to assert_equal
c53d3fd
@mitsuhiko
ETags now is truthy if it contains weak tags.
0732a7a
@mitsuhiko
Work around an stdlib bug for SSL.
97894b6
@mitsuhiko
Improved SSL support and docs for it.
2d66702
@mitsuhiko
Merge branch '0.8-maintenance'
7e0d6c4
@mitsuhiko
Merge branch '0.8-maintenance'
07d9f77
@mitsuhiko
Merge branch '0.8-maintenance'
01930a3
@mitsuhiko
Refactored the test client's redirect support
4ca6e70
Merge branch '0.8-maintenance'
8981a03
@mitsuhiko
Merge branch '0.8-maintenance'
d3b8a52
@mitsuhiko
Merge branch 'master' of github.com:mitsuhiko/werkzeug
e0bb9bc
@mitsuhiko
Merge branch '0.8-maintenance'
997196d
@mitsuhiko
Merge branch '0.8-maintenance'
3399455
@mitsuhiko
Fixed a typo in the changelog
587ea82
@mitsuhiko
Added tests for make_chunk_iter and added support for iterators inste…
3cbe355 
…ad of streams for make_line/chunk_iter
@mitsuhiko
Merge branch '0.8-maintenance'
fc05a46
@mitsuhiko
Merge branch '0.8-maintenance'
284c12b
@mitsuhiko
Refactored make_line_iter
806a032
@mitsuhiko
Merge branch '0.8-maintenance'
6d57085
@mitsuhiko
Removed stray print
c6c9442
@mitsuhiko
Removed more test naming docstrings
7dc8959
@mitsuhiko
No longer quote pluses in URL parts by the routing system. This fixes #…
88c715a 
…146
Do not quote percent sign when converting IRI to URI.
8b8a41b 
According to RFC3987, percent-encoded parts are valid in IRIs as well as in URIs and do not need to be additionaly encoded.
@jasonLaster
Copy link

jace This patch will make the test go green.

The general strategy is to update the heuristic the orders the rules so that the rules are ordered by:

  1. number of static parts
  2. number of variable parts
  3. number of paths

there's a small weighting function that normalizes for the position of the part as well, but that is fairly minor. Please let me know what you think.

Conor Hennessy and others added 8 commits July 3, 2012 05:13
Fix the 'processes' comment which is a bit misleading.
0a3b95f 
It says "number of processes to spawn", but what it does is enable
the SocketServer.ForkingMixIn which 'handles each request in a new process'.

Its value is not the number of processes but the maximum number of processes
that the ForkinMixIn will allow at the same time.
@jace
Merge branch 'master' of https://github.com/mitsuhiko/werkzeug into 0…
92fcf0d 
….8-maintenance
@SimonSapin
Remove a duplicate line
6f21882
@SimonSapin
Change the example in parse_options_header
5128769 
This seems to be a more typical usage.
@dingens
contrib.atom: Fix empty author tag bug in FeedEntry.
08e0e08 
If no author is given, don't generate an empty author tag anymore.
@agateau
Add support for the "category" element to feed entries
bcc0a33 
As per:
http://www.atomenabled.org/developers/syndication/atom-format-spec.php#element.category
Merge pull request #217 from agateau/atom-categories
47d041e 
Add support for the "category" element to feed entries
Merge pull request #211 from maix/master
cf41e9d 
contrib.atom: Fix empty author tag bug in FeedEntry.
@untitaker
Copy link
Contributor

Please use git-rebase to update your branch against master, to avoid that weird output in GitHub's web interface.

@jace
Copy link
Contributor Author

jace commented Dec 13, 2012

I'm now using my branch of werkzeug (with @jasonLaster's patch) for my production deployments Hoping this makes into @mitsuhiko's release.

@jace
Copy link
Contributor Author

jace commented Jan 2, 2013

Found a sorting error in @jasonLaster's patch. I'm getting this sequence in my URL map. This shouldn't happen:

 <Rule '/<workspace>/reports/<report>' (HEAD, POST, OPTIONS, GET) -> report>,
 <Rule '/<workspace>/reports/' (HEAD, OPTIONS, GET) -> reports>,
 <Rule '/<workspace>/reports/new' (HEAD, POST, OPTIONS, GET) -> report_new>,

Rule 3 should be above Rule 1. I'll close this pull request and attempt a clean fix on top of master.

@jace jace closed this Jan 2, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.