chore(sdk): SealedHeader generic over header
#11429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
onbjerg,
rkrasiuk,
shekhirin,
Rjected and
joshieDo
as code owners
|
not sure how to fix this test. necessary to get this merged in order to add the primitive traits module to the library, and import into |
mattsse
reviewed
Oct 3, 2024
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| /// A [`Header`] that is sealed at a precalculated hash, use [`SealedHeader::unseal()`] if you want | ||
| /// to modify header. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, AsRef, Deref, Serialize, Deserialize)] | ||
| #[add_arbitrary_tests(rlp)] | ||
| pub struct SealedHeader { | ||
| pub struct SealedHeader<H = Header> { |
There was a problem hiding this comment.
I think that's reasonable, although for header op and eth use the same type
There was a problem hiding this comment.
we shouldn't only limit this to op
mattsse
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
SealedHeadertype definition generic over header type, which is a necessary first step to useSealedHeaderinBlocktrait methods