Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font name escaping and convert js string to pdf name object #3149

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

zhangshine
Copy link
Contributor

@zhangshine zhangshine commented Apr 29, 2021

related issues #2593 and #3000

Font name should be converted to Name Object, not String.

/With#20Space  <- Name Object  ✅ 
/(With Space)  <- String ❌ 

Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good :)

@HackbrettXXX
Copy link
Collaborator

Ah, could you merge the master into your branch again. I've merged another PR since your commits.

@zhangshine
Copy link
Contributor Author

Updated!

Note: How to treat non-ascii characters is not described in PDF Reference 1.3, so I just throw an exception.

@HackbrettXXX
Copy link
Collaborator

Thanks. I think the exception is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants