tx: Remove tx_broadcast transaction from the pool #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
A0-needs_burnin
bkchr
reviewed
Apr 9, 2024
substrate/client/rpc-spec-v2/src/transaction/transaction_broadcast.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
approved these changes
Apr 15, 2024
niklasad1
reviewed
Apr 18, 2024
| @@ -106,17 +108,19 @@ where | |||
| // The unique ID of this operation. | |||
| let id = self.generate_unique_id(); | |||
|
|
|||
| // There is nothing we could do with an extrinsic of invalid format. | |||
There was a problem hiding this comment.
Maybe improve this comment to something like that spec states because this logic was not super obvious to me:
The JSON-RPC server might check whether the transaction is valid before broadcasting it. If it does so and if the transaction is invalid, the server should silently do nothing and the JSON-RPC client is not informed of the problem. Invalid transactions should still count towards the limit to the number of simultaneously broadcasted transactions.
niklasad1
approved these changes
Apr 18, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
This PR stabilizes the txBroadcast API to version 1. Ideally needs: - #4050 - #3772 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that broadcast future cleans-up the submitted extrinsic from the pool, iff the
broadcast_stopoperation has been called.This effectively cleans-up transactions from the pool when the
broadcast_stopis called.cc @paritytech/subxt-team