Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkadot-parachain simplifications and deduplications #4916

Merged
merged 14 commits into from
Jul 9, 2024
Merged

polkadot-parachain simplifications and deduplications #4916

merged 14 commits into from
Jul 9, 2024

Commits on Jul 1, 2024

  1. Simplifications and fixes

    @serban300
    serban300 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    436c4a8 View commit details
    Browse the repository at this point in the history

  2. Simplify start_node_impl() return type

    @serban300
    serban300 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    283d474 View commit details
    Browse the repository at this point in the history

  3. Deduplicate create_runner() logic

    @serban300
    serban300 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    270060b View commit details
    Browse the repository at this point in the history

  4. Deduplicate construct_partials!() and construct_async_run!()

    @serban300
    serban300 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0121d3c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Implement a more structured way to define a node spec 

    - use traits instead of bounds for `rpc_ext_builder()`,
  `build_import_queue()`, `start_consensus()`
- add a `NodeSpec` trait for defining the specifications of a node
- deduplicate the code related to building a node's components /
  starting a node
    @serban300
    serban300 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    40c3967 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Remove unneeded Net generic for DynNodeSpec

    @serban300
    serban300 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9aa7818 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge remote-tracking branch 'upstream/master' into polkadot-parachai… 

    …n-refactoring
    @serban300
    serban300 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5ef5648 View commit details
    Browse the repository at this point in the history

  2. Address code review comments

    @serban300
    serban300 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    df41f67 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge remote-tracking branch 'upstream/master' into polkadot-parachai… 

    …n-refactoring
    @serban300
    serban300 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5a30352 View commit details
    Browse the repository at this point in the history

  2. Use experimental_use_slot_based flag

    @serban300
    serban300 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1b63aa6 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'master' into polkadot-parachain-refactoring

    @serban300
    serban300 authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    90671dc View commit details
    Browse the repository at this point in the history

  2. Code review comments

    @serban300
    serban300 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9c5f5bb View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Addressing more code review comments

    @serban300
    serban300 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e5b3043 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into polkadot-parachain-refactoring

    @serban300
    serban300 authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3f977a2 View commit details
    Browse the repository at this point in the history