Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

more verbose asserts in simnet tests #3476

Merged
merged 1 commit into from
Jul 15, 2021
Merged

more verbose asserts in simnet tests #3476

merged 1 commit into from
Jul 15, 2021

Conversation

seunlanlege
Copy link
Contributor

some assert comments here and there. if statements to ensure we're matching events we care about, adds events to logs to better help debugging

@seunlanlege seunlanlege added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 15, 2021
@seunlanlege seunlanlege merged commit 956d6ae into master Jul 15, 2021
@seunlanlege seunlanlege deleted the seun-simnet-verbose-asserts branch July 15, 2021 20:12
ordian added a commit that referenced this pull request Jul 20, 2021
@ordian
Merge branch 'master' into ao-enable-disputes
74f0319 
* master:
  Update secp256k1 and remove unrequired usage (#3502)
  Bump libc from 0.2.91 to 0.2.98 (#3496)
  Bump slotmap from 1.0.2 to 1.0.5 (#3495)
  Gossip rebroadcast rate limiter (#3494)
  dependabot: ignore another git dep (#3493)
  add rustfmt toml (#3491)
  Disputes runtime (#2947)
  Bump async-process from 1.0.1 to 1.1.0 (#3122)
  remove the kubernetes helm chart (#3483)
  added pallet-proxy in rococo feature dependencies (#3486)
  Update BEEFY+MMR integration. (#3480)
  more verbose asserts (#3476)
  ci: use srtool-actions to build runtimes (#3423)
  overseer gen minor chore fixes (#3479)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grbIzl grbIzl grbIzl approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seunlanlege @grbIzl