This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
*: Update to libp2p v0.34.0 #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanb
approved these changes
Jan 13, 2021
tomaka
added
B0-silent
tomaka
approved these changes
Jan 13, 2021
tomaka
approved these changes
Jan 13, 2021
|
Do you think a burn-in is necessary? |
I think it is a good idea. I will prepare one. |
|
This pull request has been running on a Kusama full-node for ~12h. Network and general load metrics look good to me. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable changes with
libp2pv0.34.0relevant for Substrate:libp2p-tcp: Use justasync-ioinstead ofasync-std(which under the hood would useasync-io). Watch for interface changes when usingasync-io, still poll for interface changes on an interval when usingtokio. See [tcp] Port-reuse, async-io, if-watch libp2p/rust-libp2p#1887.libp2p-websocket: Switchasync-tlstofutures-tlsand thus updaterustlstov0.19. See [websocket] Switch async-tls to futures-rustls libp2p/rust-libp2p#1889.To keep dependencies in sync this pull request also updates
bytestov1.0inclient/networkprosttov0.7unsigned-varinttov0.6futures-codectoasynchronous-codec. See *: Switch futures_codec to asynchronous-codec libp2p/rust-libp2p#1908.