Use frame-decode for core extrinsic decode logic #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
commented
Sep 30, 2024
| _marker: core::marker::PhantomData<T>, | ||
| } | ||
|
|
||
| impl<T: Config> Extrinsics<T> { | ||
| /// Instantiate a new [`Extrinsics`] object, given a vector containing | ||
| /// each extrinsic hash (in the form of bytes) and some metadata that | ||
| /// we'll use to decode them. | ||
| pub fn decode_from(extrinsics: Vec<Vec<u8>>, metadata: Metadata) -> Result<Self, BlockError> { | ||
| let ids = ExtrinsicPartTypeIds::new(&metadata)?; | ||
| pub fn decode_from(extrinsics: Vec<Vec<u8>>, metadata: Metadata) -> Result<Self, Error> { |
There was a problem hiding this comment.
I moved the decoding work to this initial step.
This means that on the downside we:
- try to decode everything straight away, even if the user doesn't care (though I suspect they usually would)
- an error decoding an extrinsic will lead to a failure early on, preventing eg getting the extrinsic bytes
On the plus side, we:
- Can iterate over or
findor whatever multiple times without re-doing the decoding work each time we do these things. - Don't need to handle Results in a couple of places, since we did the work once up front.
jsdw
commented
Sep 30, 2024
| @@ -61,6 +65,63 @@ pub struct Metadata { | |||
| custom: frame_metadata::v15::CustomMetadata<PortableForm>, | |||
| } | |||
|
|
|||
| // Since we've abstracted away from frame-metadatas, we impl this on our custom Metadata | |||
| // so that it can be used by `frame-decode` to obtain the relevant extrinsic info. | |||
| impl frame_decode::extrinsics::ExtrinsicTypeInfo for Metadata { | |||
There was a problem hiding this comment.
We wouldn't normally need this if we used frame_metadata's RuntimeMetadataV15 or whatever directly, but since we abstracted it into our own Metadata crate so as to not care about the underlying version, we need to be able to get the info we need from this via the impl here.
jsdw
changed the title
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame-decodeis a crate to handle decoding historic or modern extrinsics and storage keys/values. (https://docs.rs/frame-decode/latest/frame_decode/)