Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prefer Node.js built-in fs method #1072

Closed
wants to merge 3 commits into from

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 12, 2024

The PR replaces the shelljs with the Node.js built-in fs method.

By removing the shelljs, actions-gh-pages now has fewer dependencies and faster boot-up speed.

@SukkaW SukkaW marked this pull request as ready for review March 12, 2024 09:01
@SukkaW SukkaW requested a review from peaceiris as a code owner March 12, 2024 09:01
@actions-gh-pages actions-gh-pages bot added the dependencies Pull requests that update a dependency file label Mar 12, 2024
@SukkaW SukkaW marked this pull request as draft March 12, 2024 09:25
@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 12, 2024

A few tests are failing. I am converting the PR to draft now.

@SukkaW
Copy link
Contributor Author

SukkaW commented Sep 2, 2024

The PR is superseded by #1089

@SukkaW SukkaW closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant