Add Wayland support in AppImages #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been using Wayland as my daily driver for a while now and it seems to work well enough nowadays.
|
LGTM, do you need others to test or can I merge the PR? |
MrStevns
approved these changes
Oct 6, 2021
|
I would prefer if someone who also uses Wayland could give the build I made a quick try. Since this PR is only about packaging (with all the actual heavy lifting handled by Qt), I wouldn’t consider a comprehensive test to be necessary though. Just a quick check to make sure everything is wired up correctly should be enough. |
|
Tested under X11, Wayland with XWayland, and Wayland with Wayland ( |
scribblemaniac
approved these changes
Oct 10, 2021
|
Great, thanks for giving it a try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using Wayland as my daily driver for a while now and it seems to work well enough nowadays. A build for testing is here.