Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move display options to toolbars #1734

Merged
merged 3 commits into from
Oct 30, 2022

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Oct 25, 2022

As suggested on Discord last Sunday. While I was at it I also moved the clear frame button from the tools window to the main toolbar, since it’s not actually a tool.

@J5lx J5lx added the UX Related to the way users interact with the program label Oct 25, 2022
@MrStevns
Copy link
Member

MrStevns commented Oct 27, 2022

We should resize some of the icons, so they're aligned with the rest, as currently some of them are huge in comparison.
image

@J5lx
Copy link
Member Author

J5lx commented Oct 27, 2022

You’re right, that’s pretty extreme. On Windows it’s not nearly as much of a difference. I’ll look into it.

@J5lx
Copy link
Member Author

J5lx commented Oct 29, 2022

We should resize some of the icons, so they're aligned with the rest

Done.

* Revert "Adjust icon size"

This reverts commit 67e113a.

* Change icon size of overlay toolbar icons

* Set icon size to 22 pixels
Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me 👍

Maybe we should start looking into putting the toolbar related code into its own class though? For future PR's of course.

@MrStevns MrStevns merged commit e671850 into pencil2d:master Oct 30, 2022
@J5lx J5lx deleted the display-options-toolbars branch October 30, 2022 08:32
@MrStevns MrStevns added this to the v0.6.7 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Related to the way users interact with the program
Projects
Development

Successfully merging this pull request may close these issues.

2 participants