Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated shortcuts #1866

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Updated shortcuts #1866

merged 7 commits into from
Jul 31, 2024

Conversation

HeCorr
Copy link
Contributor

@HeCorr HeCorr commented Jul 24, 2024

Somewhat related to #1016 / Fixes #1444.

This PR removes the following unused shortcuts:

  • Export Sound (Ctrl+I)
  • Preview (Alt+P)

..and adds the following missing shortcuts:

  • Export Animated GIF (Ctrl+G)
  • Toggle Center Overlay
  • Toggle Thirds Overlay
  • Toggle Golden Ratio Overlay
  • Toggle Safe Areas Overlay
  • Toggle One Point Perspective Overlay
  • Toggle Two Point Perspective Overlay
  • Toggle Three Point Perspective Overlay
  • Import Image Predefined Set
  • Import Movie Video
  • Import Movie Audio
  • Import Animated Image
  • Import Layers from project file
  • Import Palette (Append)
  • Import Palette (Replace)
  • Toggle Range Playback
  • Peg bar Alignment
  • Lock Windows
  • Reset all tools to default
  • Change Line Color (Current keyframe)
  • Change Line Color (All keyframes on layer)
  • Selection: Reposition Frames
  • Change Layer / Keyframe Opacity

Please let me know if I've missed any!

- Export Animated GIF
- Playback range
- Peg bar Alignment
- Import Image Predefined Set
- Import Movie Video
- Import Movie Audio
- Import Animated Image
- Import Layers from project file
- Import Palette (Append)
- Reset all tools to default
- Change Line Color (Current keyframe)
- Change Line Color (All keyframes on layer)
- Toggle Center Overlay
- Toggle Thirds Overlay
- Toggle Golden Ratio Overlay
- Toggle Safe Areas Overlay
- Toggle One Point Perspective Overlay
- Toggle Two Point Perspective Overlay
- Toggle Three Point Perspective Overlay
@HeCorr
Copy link
Contributor Author

HeCorr commented Jul 24, 2024

The View > Preview (Alt + P) action/menu item/shortcut seems to be unused as well. Should I go ahead and remove it?

If so, should I also remove the (seemingly abandoned) preview.cpp file?

@MrStevns
Copy link
Member

MrStevns commented Jul 24, 2024

Nice job HeCorr!

I'd recon that we remove the preview file for now, since it's been lying there for a long time and never gotten fully implemented but maybe @chchwy disagree?

@chchwy
Copy link
Member

chchwy commented Jul 24, 2024

Nice job HeCorr!

I'd recon that we remove the preview file for now, since it's been lying there for a long time and never gotten fully implemented but maybe @chchwy disagree?

It's totally fine to remove it for now. It should be added back once the feature is fully functional.

regression introduced by 2c5891d
- preview.h
- preview.cpp
- actionPreview
- CMD_PREVIEW
- CmdPreview
@HeCorr
Copy link
Contributor Author

HeCorr commented Jul 25, 2024

Preview feature and it's shortcuts removed!

I found some more missing shortcuts to add and also some that don't match their menu name:

Menu name Shortcut name
Reverse Frames Order Selection: Reverse Keyframes
Remove Frames Selection: Remove Keyframes

Should it be Frames or Keyframes?

- Selection: Reposition Frames
- Change Layer / Keyframe Opacity
@HeCorr HeCorr marked this pull request as ready for review July 27, 2024 19:45
Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

Should it be Frames or Keyframes?

We're not quite consistent regarding this, for now I'd say use the menu names as those might have translations already.

@MrStevns MrStevns merged commit cfeeed8 into pencil2d:master Jul 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Expose pending old and new functionality in the shortcut list
4 participants