Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.1 tests and confirm compatibility #1642

Closed
3 tasks done
mrook opened this issue Sep 10, 2021 · 2 comments
Closed
3 tasks done

Fix PHP 8.1 tests and confirm compatibility #1642

mrook opened this issue Sep 10, 2021 · 2 comments
Labels
core
Milestone
3.0.0-RC4

Comments

@mrook
Copy link
Member

mrook commented Sep 10, 2021 •
edited
Loading

We have a few tests failing on PHP 8.1, those need to be fixed (dependency on VersionControl_Git).

Also confirm 3.0 runs on 8.1 without issues.

  • Update to newer VersionControl_Git
  • Ignore PDepend tests on 8.1
  • Select PHPUnit 9.5.10 as lowest to fix mocking issues in 8.1
@mrook mrook added this to the 3.0.0-RC4 milestone Sep 10, 2021
@siad007
Copy link
Member

siad007 commented Sep 11, 2021 •
edited
Loading

Related to pear/VersionControl_Git#18

mrook added a commit that referenced this issue Nov 8, 2021
@mrook
Refs #1642 - bump VersionControl_Git dep
52af45c
mrook added a commit that referenced this issue Nov 8, 2021
@mrook
Refs #1642 - bump VersionControl_Git dep
a4fad1d
mrook added a commit that referenced this issue Nov 8, 2021
@mrook
Refs #1642 - bump VersionControl_Git dep
2fb89ac
@mrook
Copy link
Member Author

mrook commented Nov 8, 2021

Update:

  • VersionControl_Git was fixed
  • PDepend doesn't support 8.1 yet (so we should probably ignore these tests on 8.1)
  • The PHPUnit version we're selecting in lowest has mocking issues in 8.1

mrook added a commit that referenced this issue Nov 9, 2021
@mrook
Refs #1642 - disable pdepend tests on 8.1
74e6752
mrook added a commit that referenced this issue Nov 11, 2021
@mrook
Refs #1642 - prefer phpunit >= 9.5 to solve 8.1 mock error
ff8fb52
mrook added a commit that referenced this issue Nov 11, 2021
@mrook
Refs #1642 - prefer phpunit >= 9.5.10 to solve 8.1 mock error
16a5567
@mrook mrook mentioned this issue Nov 12, 2021
Closed
7 tasks
@mrook mrook added the core label Nov 12, 2021
@mrook mrook closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Milestone
3.0.0-RC4
Development

No branches or pull requests
2 participants
@mrook @siad007