Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phploc/phploc dependency in require blocks upgrade to PHPUnit 10+ #1703

Closed
kukulich opened this issue Apr 5, 2023 · 3 comments
Closed

phploc/phploc dependency in require blocks upgrade to PHPUnit 10+ #1703

kukulich opened this issue Apr 5, 2023 · 3 comments
Milestone

Comments

@kukulich
Copy link
Contributor

kukulich commented Apr 5, 2023

Describe the bug

We use dev-main version of Phing. I would like to upgrade our PHPUnit to version 10+ but I get this:

    - phploc/phploc[7.0.0, ..., 7.0.1] require php ^7.3 -> your php version (8.1.99; overridden via config.platform, actual: 8.2.4) does not satisfy that requirement.
    - sebastian/version 3.0.0 require php ^7.3 -> your php version (8.1.99; overridden via config.platform, actual: 8.2.4) does not satisfy that requirement.
    - Root composer.json requires phing/phing dev-main#dbf8041 -> satisfiable by phing/phing[dev-main].

I think phploc/phploc dependency should not be part of require. I think it should be in suggest section of composer.json

Steps To Reproduce
Try to install Phing and PHPUnit 10+.

Expected behavior

I would like to use Phing and PHPUnit 10+ together :)

@mrook
Copy link
Member

mrook commented Apr 6, 2023

This used to be a dev dependency (along with a bunch of others, but the work for #1693 moved that back to require.

@mrook mrook added this to the 3.0.0-RC5 milestone Apr 6, 2023
@kukulich
Copy link
Contributor Author

kukulich commented Apr 6, 2023

Yes, phploc is now fixed however it looks there's another problem with PHPUnit 10 :(

phpunit/phpunit 10.0.19 requires sebastian/version ^4.0 -> satisfiable by sebastian/version[4.0.0, 4.0.1, 4.0.x-dev].

@mrook
Copy link
Member

mrook commented Apr 6, 2023

Should be fixed now. Mind you, the PhpUnit task might not support PHPUnit 10 yet (especially if there are breaking changes).

@mrook mrook closed this as completed Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants