Fix open task test #1637
Merged
Fix open task test #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1637 +/- ##
=========================================
Coverage 58.19% 58.19%
Complexity 6964 6964
=========================================
Files 356 356
Lines 16861 16862 +1
=========================================
+ Hits 9812 9813 +1
Misses 7049 7049
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTask doesn't fail anymore when an invalid path is used.
This is because "spawn=true", this makes ExecTask (used within OpenTask) always return 0. I updated the test accordingly.
This means that OpenTask will only fail when "path" attribute is not set.