Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #1652

Merged
merged 1 commit into from
Dec 15, 2021
Merged

PHP 8.1 compatibility #1652

merged 1 commit into from
Dec 15, 2021

Conversation

x3wil
Copy link
Contributor

@x3wil x3wil commented Dec 15, 2021

Fixed deprecated message:

Return type of Phing\Type\FileList::getIterator() should either be compatible with IteratorAggregate::getIterator():Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /vendor/phing/phing/src/Phing/Type/FileList.php:88

@x3wil x3wil marked this pull request as ready for review December 15, 2021 15:18
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1652 (e2f5d98) into main (0ffdf1c) will not change coverage.
The diff coverage is n/a.

❗ Current head e2f5d98 differs from pull request most recent head ee52a0d. Consider uploading reports for the commit ee52a0d to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1652   +/-   ##
=========================================
  Coverage     58.14%   58.14%           
  Complexity     7007     7007           
=========================================
  Files           356      356           
  Lines         16912    16912           
=========================================
  Hits           9833     9833           
  Misses         7079     7079           
Impacted Files Coverage Δ
src/Phing/Type/FileList.php 52.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffdf1c...ee52a0d. Read the comment docs.

@mrook mrook merged commit b964fcd into phingofficial:main Dec 15, 2021
@mrook mrook added this to the 3.0.0-RC4 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants