Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make vanish public API so people can add deferred render behavior if desired #808

Closed
wants to merge 1 commit into from
Closed

make vanish public API so people can add deferred render behavior if desired #808

wants to merge 1 commit into from

Conversation

davekaro
Copy link
Contributor

@davekaro davekaro commented Oct 4, 2024

Opening this as a discussion point, do you want to make vanish public API since Phlex::DeferredRender is gone now?

@joeldrapper
Copy link
Collaborator

We renamed it from __vanish__ to vanish to indicate that it is part of Phlex’ public API. Do you think it should be public on the component too?

@davekaro
Copy link
Contributor Author

davekaro commented Oct 5, 2024

Ahh yes that’s right. No I think it’s good as is, or at least I have no need for it to be public on the component.

Do we still want the tests for vanish? I could make some more if yes

@davekaro davekaro closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davekaro @joeldrapper