Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-e affects *1, *2, *3 #659

Closed
mfikes opened this issue Feb 27, 2018 · 0 comments · Fixed by #915
Closed

-e affects *1, *2, *3 #659

mfikes opened this issue Feb 27, 2018 · 0 comments · Fixed by #915

Comments

@mfikes
Copy link
Member

mfikes commented Feb 27, 2018 

$ planck -e ':a' -e ':b' -e ':c' -e '*1' -e '*2' -e '*3' -e ':done'
:a
:b
:c
:c
:b
:a
:done

$ clj -e ':a' -e ':b' -e ':c' -e '*1' -e '*2' -e '*3' -e ':done'
:a
:b
:c
:done
@mfikes mfikes mentioned this issue Feb 27, 2018
Open
pyrmont added a commit to pyrmont/planck that referenced this issue Apr 23, 2019
@pyrmont
Fix -e arguments affecting *1, *2, *3 and *e
9a4d3d7 
Planck's evaluation logic treated evaluation of text entered at a REPL
and evaluation of arguments to `-e` the same. This resulted in the
result variables (`*1`, `*2`, `*3`) being set in both cases. As noted
in planck-repl#659, this is not the behaviour of Clojure. This commit fixes planck-repl#659 by
testing whether the evaluation is occurring in a REPL environment.
@pyrmont pyrmont mentioned this issue Apr 23, 2019
Merged
mfikes pushed a commit that referenced this issue May 7, 2019
@pyrmont @mfikes
Fix -e arguments affecting *1, *2, *3 and *e (#915)
59c7dd7 
Planck's evaluation logic treated evaluation of text entered at a REPL
and evaluation of arguments to `-e` the same. This resulted in the
result variables (`*1`, `*2`, `*3`) being set in both cases. As noted
in #659, this is not the behaviour of Clojure. This commit fixes #659 by
testing whether the evaluation is occurring in a REPL environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix -e arguments affecting *1, *2, *3 and *e pyrmont/planck
1 participant
@mfikes