Add option to remove breaks via timeline context menu #28707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
reviewed
Jul 3, 2024
| Add(new TimelineBreak(breakPeriod)); | ||
| Add(new TimelineBreak(breakPeriod) | ||
| { | ||
| OnDeleted = b => breaks.Remove(b), |
There was a problem hiding this comment.
I believe this should be accompanied by a changeHandler.SaveState call for undo/redo/"do you want to save your changes" functionalities.
peppy
previously approved these changes
Jul 3, 2024
peppy
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because people keep asking for it.
It's not very smartly implemented, meaning that you can remove it, but if you change any object and the automatic generator determines that a break should be where you just removed it, it'll add another one back. I can probably do something about that but maybe let's just start simple and see how many people complain?