Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ValueTuples #1012

Merged
merged 9 commits into from
Aug 25, 2021
Merged

Support for ValueTuples #1012

merged 9 commits into from
Aug 25, 2021

Conversation

XavierAP
Copy link
Contributor

@XavierAP XavierAP commented Nov 22, 2020

Fixes #1007

@XavierAP
Copy link
Contributor Author

Auto checks are broken in master, can be fixed by #960

Copy link
Owner

@praeclarum praeclarum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! I just have some changes to make sure we don't break backwards binary compatibility and also so we don't change semantics for existing reference types.

Thanks for the hard work!

src/SQLite.cs Outdated Show resolved Hide resolved
src/SQLite.cs Show resolved Hide resolved
src/SQLite.cs Show resolved Hide resolved
src/SQLite.cs Outdated Show resolved Hide resolved
src/SQLite.cs Show resolved Hide resolved
src/SQLite.cs Show resolved Hide resolved
@XavierAP
Copy link
Contributor Author

XavierAP commented Dec 7, 2020

@praeclarum thanks, good points. I'll make the changes, and solve the merge conflict, in the coming days when I have time.

@XavierAP
Copy link
Contributor Author

@praeclarum I've done all changes you requested, please take another look :-)

@erlenddahl
Copy link

Is there anything more missing for this to be merged? Would be great to have!

@praeclarum
Copy link
Owner

Sorry for the delay getting this in!

@praeclarum praeclarum merged commit 47957c5 into praeclarum:master Aug 25, 2021
@XavierAP XavierAP deleted the issue1007 branch August 25, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLiteConnection.Query does not work with ValueTuples
3 participants