Added CalculiX case for flow-over-heated-plate #271

boris-martin · 2022-04-10T13:03:43Z

Context

To showcase the improvements to 2D-3D coupling with CalculiX (precice/calculix-adapter#94, precice/calculix-adapter#92) and the support of hexaedral elements on face meshes (precice/calculix-adapter#91), an new CHT case can be designed with CalculiX. It also improves the list of illustrated cases with heat transfer, as the only CalculiX tutorial here with heat transfer is the heat exchanger, which is very specific (Robin BC's with explicit coupling on a steady-state simulation). This shows how to use DIrichlet-Neumann coupling on transient problems.

Closes #103

Todolist

Cleanup of the case file and precice-config
Add a run.sh and a cleanup file
Validation of the case. (For now: looks good but not exactly similar to other cases. Detailed comparison to do)
format Python script (if we keep it ?)

uekerman · 2022-04-11T11:37:59Z

flow-over-heated-plate/README.md

@@ -53,6 +53,9 @@ cd solid-fenics

 in order to use OpenFOAM and FEniCS for this test case. Feel free to try different combinations, they should all run and give approximately similar results.

+
+Note that to use CalculiX as solid solver, the configuration file `precice-config-calculix.xml` must be used instead of `precice-config.xml`. The CalculiX case is already configured to use it, but the fluid solver must be adapted. Modify the `system/preciceDict` file in the OpenFOAM case to use the correct one. This is necessary because CalculiX use different meshes for the temperature (read at the nodes) and for the heat flux, computed on face centers.


This is problematic in my opinion. The CalculiX participant should use the same config. We need to bring temperature and heat flux values on the same mesh.

Not sure what's the right approach then. I think we can apply concentrad heat fluxes on nodes instead of faces, but then we'd need a conservative mapping, so here we go again for a new config file. Unless we want to add some dirty hack like "read fluxes on nodes then convert them to CalculiX faces fluxes, with some kind of averaging of a node for a given face"?
That would require a significant upgrade of the adapter but should be doable. Then we'd need to have either fluxes on faces or on nodes for backwards compatibility.

To be sure: do you dislike the fact that we need a different config for a tutorial, or the fact that CalculiX in general has two kinds of meshes? In the first case we could simply have a different tutorial?

Poke @MakisH as we discussed a bit about this.

To be sure: do you dislike the fact that we need a different config for a tutorial, or the fact that CalculiX in general has two kinds of meshes? In the first case we could simply have a different tutorial?

The first. Yes, last resort would be a different tutorial.

So shall I try to add a mesh conversion inside CalculiX ? I don't think there's a way to keep one config in the current state of the adapter.

This depends on how complicated it would get.
Doable -> let's do it
Complicated and hard to maintain -> better additional tutorial

I'll investigate then. Parts look easy (map from vertices to faces) but other directions should be harder. I'll let you know

I also think that extending the CalculiX adapter to handle both cases would probably be the most sustainable solution here. We should still inform the user that there is an additional interpolation happening under the hood, though.

Since the easiest right now is to provide an additional tutorial, @boris-martin already moved the case to flow-over-heated-plate-calculix (and it already runs for me, till the last time step where CalculiX reports something that looks like a "double free" error, as currently known).

The name flow-over-heated-plate-calculix sounds a bit too specific, though. We do provide it just because of the current state of the CalculiX adapter, but can we find a more generic name? Even flow-over-heated-plate-two-meshes or something similar.

If we really want to have it as something temporary, then let's keep the -calculix part and let's document in the README.md that this is intended as a first step and will be eventually merged.

flow-over-heated-plate-two-meshes Looks good to me if you think that's a better idea.

MakisH · 2022-07-19T16:37:13Z

Since people are asking about this case, this PR is currently marked as "draft" and it seems to not be ready to run yet. For me, running (with ccx_preCICE -i solid -precice-participant Solid, as a run.sh is not yet available), leads to a configuration error:

---[precice]  This is preCICE version 2.4.0
---[precice]  Revision info: v2.4.0
---[precice]  Build type: Debug
---[precice]  Configuring preCICE with configuration "../precice-config.xml"
---[precice]  I am participant "Solid"
Using quasi 2D-3D coupling
Set ID Found 
---[precice] ERROR:  The given mesh name "Solid-Mesh-nodes" is unknown to preCICE. Please check the mesh definitions in the configuration.

Just check again in a few weeks.

boris-martin · 2022-07-19T17:13:28Z

It's because the wrong precice-config is used. The precice-config-calculix must be used instead. I'll clean this up and move it to another directory with correct configuration. (Also, up-to-date develop version of the adapter is needed)

boris-martin · 2022-07-19T22:27:09Z

Refactored this to be a new tutorial in a new folder. Big part of the diff is the copy of the fluid-openfoam from the non-CalculiX version of this. I have yet to write a new README, and there's a small issue where CalculiX crashes at the last time window which i'll have to investigate. Otherwise, ready for review.
If you want to run it, make sure you're using the develop branch of the CalculiX adapter.

MakisH · 2022-07-20T15:44:32Z

I ran the case and the results look good, but only after a few iterations (this looks more like a steady-state case). In the beginning, the temperature around the interface is quite off:

flow-over-heated-plate-openfoam-calculix.mp4

Useful information for the README: here I converted the CalculiX results to VTK using the frd converter bundled in the CalculiX adapter. CalculiX produces 1000 result files, which one can then synchronize with OpenFOAM using the "Temporal Shift Scale" filter, using a scale of 0.01. Since the temperature is named differently in each solver, a "group" filter does not work, but setting the same scale to both (from 300K to 310K) helps.

boris-martin · 2022-07-20T16:36:10Z

I have the same results. I'm a bit surprised we don't get a continuous temperature after a few iterations (since coupling is implicit, I thought it'd be enough). I don't know if it's a bug or if it's due to bad choice of mesh/mapping.

flow-over-heated-plate-calculix/README.md

MakisH · 2022-07-20T19:49:52Z

flow-over-heated-plate-calculix/README.md

@@ -0,0 +1,53 @@
+---
+title: Flow over heated plate with two meshes
+permalink: tutorials-flow-over-heated-plate-two-meshes.html


Don't forget to add this to the sidebar on the website (separate PR).

flow-over-heated-plate-calculix/solid-calculix/generate_mesh.py

MakisH · 2022-07-20T20:08:44Z

Thanks for the README! Still open:

The strange "double free" error at the end of the CalculiX simulation.
Closer look at the results / tuning

Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>

uekerman · 2022-07-21T08:08:01Z

Let's also add a link from the normal flow-over-heated-plate to this one.

boris-martin · 2022-07-21T08:23:09Z

Let's also add a link from the normal flow-over-heated-plate to this one.

There's already one in the Setup description

uekerman · 2022-07-21T08:29:56Z

There's already one in the Setup description

Is there? This PR only touches flow-over-heated-plate-calculix right now, right?

boris-martin · 2022-07-21T08:33:00Z

Oh my bad I misread. There's one in the other direction, but the one you mention is indeed missing.

boris-martin · 2022-07-25T23:08:26Z

I changed the solid mesh to make it much more refined (~same vertex density as the fluid at the interface). If I do that and modify OpenFOAM to have one output every 0.01s (i.e. one per time window), I get something good-looking (using the time shift you recommended, which I'll have to document). Also, I quite increased the implicit coupling accuracy (reduced tolerance, 1e-9 instead of 1e-5.:

I had weird things using the original output interval (0.20), like times being [0.19, 0.20, 0.39, 0.40, ...]. @MakisH I need your OpenFOAM expertise to understand that part.

In conclusion, I got good results by changing a lot of things, I'll have to isolate the dominant one because I kind of lost track of all these changes. But we're getting there, and the adapters aren't broken :)

MakisH · 2022-07-26T06:49:31Z

I had weird things using the original output interval (0.20), like times being [0.19, 0.20, 0.39, 0.40, ...]. @MakisH I need your OpenFOAM expertise to understand that part.

This is a known issue we can do little about: precice/openfoam-adapter#26

That's why at the end of every OpenFOAM run.sh, we call the removeObsoleteFolders.

precice-bot · 2022-08-03T20:35:06Z

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/installation-problem-with-calculix-2-19-adapter/1124/8

boris-martin · 2022-08-09T19:32:00Z

I ran again without changing preCICE implicit coupling tolerance and results look satisfying to me. Should be getting ready then. I think the calculix crash at the end was solved in precice/calculix-adapter#102.
Updated the main README too.

flow-over-heated-two-meshes/README.md

flow-over-heated-two-meshes/fluid-openfoam/system/controlDict

Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>

MakisH · 2022-08-10T05:30:28Z

I realize too late that this needs two more fixes:

Making OpenFOAM write as frequently as CalculiX did not help and actually made the simulation quite slow. I should have actually thought this a bit longer and suggested to make CalculiX write as infrequently as OpenFOAM. But most importantly, we should probably write in every coupling time. Otherwise, we get inconsistencies between coupling times. But this may also hide a deeper problem.
We should make the CalculiX plate as thick as the OpenFOAM channel. Right now, the one is 0.2m thick, and the other 0.5m, leading to strange visuals in paraview.

The branch still exists, but I think we will not be able to merge the same MR a second time, so maybe open a separate PR.

This reverts commit 9d722d3.

boris-martin and others added 2 commits April 10, 2022 14:51

Added mesh, case and config

7a3d7ec

Updated instructions for CalculiX.

c394c45

uekerman reviewed Apr 11, 2022

View reviewed changes

boris-martin added 4 commits July 20, 2022 00:12

Moved to new folder

b3e7612

restored README

151f6a4

removed case

22713ab

removed redundant file

a237300

boris-martin marked this pull request as ready for review July 19, 2022 22:20

boris-martin requested a review from uekerman July 19, 2022 22:20

boris-martin changed the base branch from master to develop July 19, 2022 22:28

MakisH self-requested a review July 20, 2022 07:22

boris-martin added 5 commits July 20, 2022 19:40

first README draft

a81e6c4

format

103269b

expanded post processing

2961118

format

a4fafda

format with correct args

9c1bac2

MakisH reviewed Jul 20, 2022

View reviewed changes

boris-martin and others added 2 commits July 20, 2022 23:39

Update flow-over-heated-plate-calculix/README.md

d209577

Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>

added adapter version

2ca8df8

moved generate mesh script into run

d28c1c6

fixed non matching end times

bb8caea

boris-martin mentioned this pull request Jul 24, 2022

Fixed crash when freeing unused pointers precice/calculix-adapter#102

Merged

refined solid mesh

e626a5a

boris-martin added 3 commits August 9, 2022 18:40

fix wrong link in readme

d9fc61b

added explanation for time shift

561f099

added reference to main tutorial

6094f81

boris-martin and others added 2 commits August 9, 2022 21:32

Merge branch 'develop' into flow_heated_plate_calculix

4d706d0

renamed dir

f2ee3ae

MakisH reviewed Aug 9, 2022

View reviewed changes

flow-over-heated-two-meshes/README.md Outdated Show resolved Hide resolved

flow-over-heated-two-meshes/README.md Outdated Show resolved Hide resolved

flow-over-heated-two-meshes/README.md Outdated Show resolved Hide resolved

MakisH reviewed Aug 9, 2022

View reviewed changes

flow-over-heated-two-meshes/fluid-openfoam/system/controlDict Outdated Show resolved Hide resolved

boris-martin and others added 6 commits August 9, 2022 23:05

Update OpenFOAM write frequency

67ada23

Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>

concision

f5f7512

Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>

Improved post-processing description

2bc83ed

Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>

renamed folder

7c1818b

added blank line

9e03886

format

38624d9

boris-martin merged commit 9d722d3 into develop Aug 9, 2022

boris-martin added a commit that referenced this pull request Aug 10, 2022

Revert "Added CalculiX case for flow-over-heated-plate (#271)"

3fb8569

This reverts commit 9d722d3.

MakisH deleted the flow_heated_plate_calculix branch November 22, 2023 09:37

MakisH mentioned this pull request Mar 20, 2024

Flow-over-heated-plate-two-meshes: Different thickness of each domain #455

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added CalculiX case for flow-over-heated-plate #271

Added CalculiX case for flow-over-heated-plate #271

boris-martin commented Apr 10, 2022 •

edited

Loading

uekerman Apr 11, 2022

boris-martin Apr 11, 2022

uekerman Apr 12, 2022

boris-martin Apr 12, 2022

uekerman Apr 12, 2022

boris-martin Apr 12, 2022

MakisH May 23, 2022

MakisH Jul 20, 2022

boris-martin Jul 20, 2022

MakisH commented Jul 19, 2022

boris-martin commented Jul 19, 2022

boris-martin commented Jul 19, 2022

MakisH commented Jul 20, 2022

boris-martin commented Jul 20, 2022

MakisH Jul 20, 2022

MakisH commented Jul 20, 2022

uekerman commented Jul 21, 2022

boris-martin commented Jul 21, 2022

uekerman commented Jul 21, 2022

boris-martin commented Jul 21, 2022

boris-martin commented Jul 25, 2022

MakisH commented Jul 26, 2022

precice-bot commented Aug 3, 2022

boris-martin commented Aug 9, 2022

MakisH commented Aug 10, 2022 •

edited

Loading

		@@ -53,6 +53,9 @@ cd solid-fenics

		in order to use OpenFOAM and FEniCS for this test case. Feel free to try different combinations, they should all run and give approximately similar results.


		Note that to use CalculiX as solid solver, the configuration file `precice-config-calculix.xml` must be used instead of `precice-config.xml`. The CalculiX case is already configured to use it, but the fluid solver must be adapted. Modify the `system/preciceDict` file in the OpenFOAM case to use the correct one. This is necessary because CalculiX use different meshes for the temperature (read at the nodes) and for the heat flux, computed on face centers.

Added CalculiX case for flow-over-heated-plate #271

Added CalculiX case for flow-over-heated-plate #271

Conversation

boris-martin commented Apr 10, 2022 • edited Loading

Context

Todolist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MakisH commented Jul 19, 2022

boris-martin commented Jul 19, 2022

boris-martin commented Jul 19, 2022

MakisH commented Jul 20, 2022

boris-martin commented Jul 20, 2022

Choose a reason for hiding this comment

MakisH commented Jul 20, 2022

uekerman commented Jul 21, 2022

boris-martin commented Jul 21, 2022

uekerman commented Jul 21, 2022

boris-martin commented Jul 21, 2022

boris-martin commented Jul 25, 2022

MakisH commented Jul 26, 2022

precice-bot commented Aug 3, 2022

boris-martin commented Aug 9, 2022

MakisH commented Aug 10, 2022 • edited Loading

boris-martin commented Apr 10, 2022 •

edited

Loading

MakisH commented Aug 10, 2022 •

edited

Loading