Add elastic-tube-1d watchpoint plot #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsimonis
force-pushed
the
add-elastic-tube-1d-watchpoint-plot
branch
from
f6f89f5
to
08e9163
Compare
|
I removed the run-all script and changed This omits the solver participant from the plots, but should be practical enough to detect problems. |
MakisH
approved these changes
Feb 19, 2024
|
It's not possible to get the solid participant from the run files. So hard coding a name can easily become incorrect. Not sure how to solve this. |
You checked in a plot, which you generated after running some combinations, right? I am only asking that you document which Solid participant you used, nothing more. |
|
FYI the new image looks like this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #434 and #435.
It adds a watchpoint at x=5 of the fluid solver as well as a plot of for pressure and diameter over all time steps.
Scripts run-all.sh and plot-all.sh generate this plot.