refactor: refactor pixi::consts and pixi::config into separate crates #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-arts
reviewed
Jul 29, 2024
baszalmstra
reviewed
Jul 29, 2024
wolfv
changed the title
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
baszalmstra
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors these types into their seperate crates.
I've kept consts in the const namespace, and made the use of it consistent, i.e never import from const directly but always append with the namespace. I've kept the const module for that reason as I like to avoid
mod as other_modwhenever possible.Config I've also put in it seperate crate, this could use a subsequent refactor because the lib file is much too big for my taste, I think that refactor is a bit overdue tbh.
I've kept the refactor limited to moving of the types, and have not changed anything significant, I believe the review would have been impossible otherwise.
cc @wolfv