docs: fix mlx feature in "multiple machines" example #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-arts
reviewed
Aug 8, 2024
The example as it was would not solve, it ends with a fairly
obscure error:
```
× failed to solve the conda requirements of 'mlx' 'osx-arm64'
╰─▶ Cannot solve the request because of: mlx >=0.5.0,<0.6.0 cannot be installed because there are no viable options:
└─ mlx 0.5.0 | 0.5.0 | 0.5.0 | 0.5.0 | 0.5.0 | 0.5.1 | 0.5.1 | 0.5.1 | 0.5.1 | 0.5.1 would require
└─ __osx >=13.3, for which no candidates were found.
```
This was already found previously in
prefix-dev#562 (comment),
and the fix is to add a minimum macOS version.
Note that the conda-forge package metadata (saying >=13.3) is also incorrect,
the 13.5 minimum added to the example comes from the MLX docs:
https://ml-explore.github.io/mlx/build/html/install.html#
While we're at it, also update to a recent MLX version.
rgommers
force-pushed
the
doc-fix-multimachine-example
branch
from
859cc61
to
094ba23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example as it was would not solve, it ends with a fairly obscure error:
This was already found previously in #562 (comment), and the fix is to add a minimum macOS version. Note that the conda-forge package metadata (saying >=13.3) is also incorrect, the 13.5 minimum added to the example comes from the MLX docs: https://ml-explore.github.io/mlx/build/html/install.html#
While we're at it, also update to a recent MLX version.