Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make proper use of NamedChannelOrUrl #1820

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Aug 15, 2024

Partly fixes #1764
Fixes #1791

We didn't read the channel name in the mapping correctly anymore. This fixes that.

This now forces the user to have the channel in the mapping defined as an actual channel. Giving the user this error:

❯ pixi install
  × Defined conda-pypi-map channel: bla is missing from the channels, which are: conda-forge, robostack, https://fast.prefix.dev/conda-forge/, bioconda

Added a test to verify

@ruben-arts
Copy link
Contributor Author

@nichmor The tests are failing but to me it seems like I actually fixed a bug.

assert_eq!(boltons_first_purl.name(), "boltons");
assert_eq!(
boltons_first_purl.qualifiers().get("source").unwrap(),
PurlSource::ProjectDefinedMapping.as_str()
);

Here it says that it should take boltons from the ProjectDefinedMapping, but in my new version it tells me it comes from the compressed mapping. To me that seems correct as the custom mapping doesn't have boltons and we don't provide a hash. So it can only come from the compressed_mapping.

Could you tell me whats up

@ruben-arts
Copy link
Contributor Author

@baszalmstra This reintroduces the channel-config as we're comparing the repodata with the channel thus we require the configuration. Could you rereview?

@baszalmstra baszalmstra merged commit 6315217 into prefix-dev:main Aug 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants