feat: extend pixi clean cache with more cache options #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
reviewed
Aug 21, 2024
|
@tdejager you can already do that with |
baszalmstra
requested changes
Aug 22, 2024
crates/pixi_consts/src/consts.rs
Outdated
| @@ -19,7 +19,12 @@ pub const SOLVE_GROUP_ENVIRONMENTS_DIR: &str = "solve-group-envs"; | |||
| pub const PYPI_DEPENDENCIES: &str = "pypi-dependencies"; | |||
| pub const TASK_CACHE_DIR: &str = "task-cache-v0"; | |||
| pub const PIXI_UV_INSTALLER: &str = "uv-pixi"; | |||
| pub const CONDA_PACKAGE_CACHE_DIR: &str = "pkgs"; | |||
| pub const CONDA_REPODATA_CACHE_DIR: &str = "repodata"; | |||
There was a problem hiding this comment.
These values are also in rattler_cache we should use those!
There was a problem hiding this comment.
Now using those, added rattler_cache as a dep to the main pixi and use it as a workspace dep in pixi_consts
There was a problem hiding this comment.
can we then get rid of these constants? or reexport them?
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
nichmor
reviewed
Aug 22, 2024
| @@ -668,7 +669,9 @@ impl<'p> UpdateContextBuilder<'p> { | |||
| let project = self.project; | |||
| let package_cache = match self.package_cache { | |||
There was a problem hiding this comment.
I think we can simplify this part by using combinators
let package_cache = self.package_cache.or_else(|| pixi_config::get_cache_dir()?.join(consts::CONDA_PACKAGE_CACHE_DIR))
baszalmstra
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
--exec--mapping--repodatato theclean cachefunction.Also renames the mapping cache dir to
conda-pypi-mapping