feat: add build-isolation options #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
|
Would be good if could start reviewing this @baszalmstra @ruben-arts |
ruben-arts
reviewed
Aug 30, 2024
|
@ruben-arts also added an example that builds/installs detectron2 from source. |
ruben-arts
approved these changes
Aug 30, 2024
|
Thanksss |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to do build-isolation.
Would be good to get in: astral-sh/uv#6517, so it's more useful in issue like: #1880 and #1834
edit:
The 6517 PR mentioned above has been integrated, started UV upgrade here: #1936 which we need to have the added test to succeed.
edit
All prequisites are in.
TODO: