fix: use two in memory indexes, for resolve and builds #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
Sep 3, 2024
|
Seems to be some other problem cropping up, converting into draft. |
|
Seemed to be a corrupted cargo git cache, never had that one before.. Back to undrafting. |
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
2 tasks
|
I fixed these failing tests in #1973 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the resolver use two memory indexes, one for the resolution process and one for the potential building of wheels. Even though uv uses different internal revolvers it was sometimes still getting data that was overridden by us during wheel builds, which was unexpected.
This was cropping up in issues like #1686. We've made a minimal version of the lock file where this problem was occuring. And added that as a test.
Fixes #1686