Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VimuxOpenRunner not working for versions of tmux < 3.4 #228

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

jmriego
Copy link
Contributor

@jmriego jmriego commented Jul 26, 2024

This is a fix for #225 to allow VimuxOpenRunner to work for versions of tmux < 3.1

The breaking change was introduced in #217 and was caused because even though the -l flag existed for a long time, it never supported percentage signs until tmux 3.1. Relevant part of their CHANGES

* Add support for percentage sizes for resize-pane ("-x 10%"). Also change
  split-window and join-pane -l to accept similar percentages and deprecate the
  -p flag.

This is an old tmux version so in my opinion the most logical thing is to support by default the newer tmux syntax. The default for g:VimuxHeight is 20%.
This won't support the old tmux flag -p so for older versions you'd only be able to specify the size of the split in columns/lines.

Copy link
Member

@mvanderkamp mvanderkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This could cause some confusion for anyone who has set this variable but that is easily fixed by users.

@alerque alerque merged commit c4ffa0b into preservim:master Jul 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants