Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local dev (revert webpack 5.5.0 → 6.0.0) #1805

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fix local dev (revert webpack 5.5.0 → 6.0.0) #1805

merged 2 commits into from
Dec 2, 2021

Conversation

tobiasahlin
Copy link
Contributor

Ever since #1790, it seems like builds are failing, and running npm start throws webpack-related errors. This PR reverts the version bump of webpack to fix those errors.

/cc @primer/css-reviewers

@tobiasahlin tobiasahlin requested a review from a team as a code owner December 2, 2021 09:44
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: b9b43d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

siddharthkp
siddharthkp approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this version is compatible with gatsby and the local setup is working again.

@siddharthkp
Copy link
Member

siddharthkp commented Dec 2, 2021 •
edited
Loading

@tobiasahlin

Works now! thank you!

are you still seeing this warning?

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module:
/Users/sid/code/primer/css/docs/node_modules/gatsby-recipes/node_modules/remark-mdx/index.js
require() of ES modules is not supported.

@langermank langermank merged commit 99537d3 into main Dec 2, 2021
@langermank langermank deleted the tobiasahlin/fix-local-dev-webpack branch December 2, 2021 19:16
@primer-css primer-css mentioned this pull request Dec 2, 2021
Merged
@simurai simurai mentioned this pull request Dec 3, 2021
Merged
@primer-css primer-css mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@langermank langermank langermank approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan was automatically assigned from primer/css-reviewers

@simurai simurai Awaiting requested review from simurai

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasahlin @siddharthkp @langermank