Misspell warning in SRCREV when using SRCREV_FORMAT syntax #468
Comments
|
The problem is a different one |
from SRC_URI to identify variables names.
In before this issue was also hidden due to too high confidence
setting in the best match function.
Lower the confidence to 0.5 and add named resources for
at leats SRCREV_{x} pattern as valid and known variables.
Closes #468
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
from SRC_URI to identify variables names.
In before this issue was also hidden due to too high confidence
setting in the best match function.
Lower the confidence to 0.5 and add named resources for
at leats SRCREV_{x} pattern as valid and known variables.
Closes #468
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
|
Hi! I checked versions with this pip command: Am I missing something? |
|
@fbertux I can't reproduce your issue - as you can see this test code by you is part of the test cases now and all of them pass without any issue. Could you come up with another way that issue occurs to you, please |
|
The issue happens for all recipes that have To me, if I change the znc recipe by adding an override before line |
|
Run in python:3.8 docker container. I suspect something is off with your local python site-packages dir. Could you please try to remove the linter and install it entirely fresh |
|
Did you change the recipe by adding an override before I did these steps using Docker: But I changed the line 6 to This recipe will show the issue: |
|
@fbertux I finally found it, it is indeed an interesting corner case - the filename is important here - wrote a patch and added a test case, to avoid future regressions. |
so we could catch valid vars like expanded statements
of SRCREV_${PN} from the extra resources list.
The error surfaced only if a named resource has the very
same name as one of the valid package names.
Closes #468
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
so we could catch valid vars like expanded statements
of SRCREV_${PN} from the extra resources list.
The error surfaced only if a named resource has the very
same name as one of the valid package names.
Closes #468
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
Hi!
There is an issue, seems related to version 2.13.0, that throws an oelint.vars.mispell warning if a recipe uses an override and also has SRCREV_FORMAT.
To reproduce the issue, we can use the following recipe:
and run the following command:
I see the following message:
But removing line
FOO:qemux86 = "1"the oelint.vars.mispell warning doesn't appear.I ran the sequence above using oelint-parser version 2.12.3, using the command
pip3 install --force-reinstall -v "oelint-parser==2.12.3", and didn't see the oelint.vars.mispell warning. Changing to version 2.13.0,pip3 install --force-reinstall -v "oelint-parser==2.13.0", I can reproduce the issue. The issue persists in the current 2.13.3 release.Is this a known issue? Do you need additional information?
Thanks!
The text was updated successfully, but these errors were encountered: