Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to rustls 0.22.1, tokio-rustls 0.25.0 #106

Closed
wants to merge 2 commits into from

Conversation

eric-seppanen
Copy link

I'm not sure if there's any interest in doing this, because it would be a major breaking change and the 0.6 release just went out a few weeks ago.

But since I went through the motions of making it work, I figured I'd at least post this so others could decide whether this change was desirable.

I have tested it in my own axum project, and it seemed to work, but I can't attest to more than that.

…5 first which is unreleased."

tokio-rustls 0.25.0 is released now, so we can switch back to rustls
0.22.

This reverts commit 3003040.
This includes a breaking change to RustlsConfig::from_der; this is
because rustls 0.22 no longer has a way to accept a private key in DER
Vec<u8> form.
@eric-seppanen eric-seppanen mentioned this pull request Jan 4, 2024
@diptanu
Copy link

diptanu commented Feb 23, 2024

What is the status of this thing? I had to revert to rustls 0.21 because of the incompatibilities.

@eric-seppanen
Copy link
Author

rustls 0.23 is out now, so this PR is probably not of much use except as a starting point for working on the next upgrade.

MaxFangX pushed a commit to lexe-app/axum-server that referenced this pull request Mar 26, 2024
This patch is from this axum-server draft PR, credit to @eric-seppanen:
- programatik29#106

It looks like axum-server will skip directly to 0.23, so this patch can
be removed then. programatik29#112
@MaxFangX
Copy link

MaxFangX commented Mar 26, 2024

Thanks for this; we are adopted these changes as a patch in our crate graph during our process of upgrading to rustls@0.22. Major parts of the ecosystem haven't upgraded to 0.23 yet (including crates like reqwest and hyper-rustls), and if others have a relatively deep integration with rustls like us, they will have issues with client and server TLS configs being incompatible. Because of this, there is value in merging this PR so there is a version of axum-server published on crates.io that uses rustls@0.22. But maybe this is a problem experienced only by a marginal number of users which happens to include us. We've worked around it anyhow; just sharing our perspective.

@programatik29
Copy link
Owner

#124 closes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants