Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdtm corrupts packages manager on tools removal #52

Closed
Mzack9999 opened this issue Jan 24, 2023 · 0 comments · Fixed by #61
Closed

pdtm corrupts packages manager on tools removal #52

Mzack9999 opened this issue Jan 24, 2023 · 0 comments · Fixed by #61
Assignees
@xm1k3
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
pdtm v0.0.4

Comments

@Mzack9999
Copy link
Member

pdtm version:

main|dev

Current Behavior:

If a tool is already installed in a system directory via apt|snap|brew pdtm just removes it after performing an exec.LookPath, leading to package manager security warnings and blocking system updates due to package corruption.

Expected Behavior:

Only binaries installed previously in the specified path should be removed

Steps To Reproduce:

# ls /usr/bin/mapcidr
/usr/bin/mapcidr
# pdtm -bp /tmp/ -ra
...
[INF] removing mapcidr...
[INF] removed mapcidr
...
# mapcidr
bash: /usr/bin/mapcidr: No such file or directory
# snap refresh
sh: 1: /usr/bin/mapcidr: not found
# snap remove mapcidr
sh: 1: /usr/bin/mapcidr: not found

Notes: not yet verified but also install, update and execution should be verified for potential similar errors
@Mzack9999 Mzack9999 added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Jan 24, 2023
@xm1k3 xm1k3 linked a pull request Jan 30, 2023 that will close this issue
pdtm corrupts packages manager on tools removal #61
Merged
@xm1k3 xm1k3 self-assigned this Jan 30, 2023
@Mzack9999 Mzack9999 mentioned this issue Jan 31, 2023
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Feb 17, 2023
@ehsandeep ehsandeep added this to the pdtm v0.0.4 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xm1k3 xm1k3

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
pdtm v0.0.4
Development

Successfully merging a pull request may close this issue.

pdtm corrupts packages manager on tools removal projectdiscovery/pdtm
3 participants
@ehsandeep @Mzack9999 @xm1k3