Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip install on update with missing tool #60

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 27, 2023

Description

  • Skip install on update missing tool
  • Minor updates and optimizations

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 27, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 27, 2023
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but it looks like another issue in the update option, as per the example, even tlsx, katana is installed on the latest version, but it is still getting updated everytime -ua option is used.

./pdtm

1. subfinder (latest) (2.5.5)
2. dnsx (latest) (1.1.1)
3. naabu (not supported)
4. httpx (latest) (1.2.6)
5. nuclei (latest) (2.8.8)
6. uncover (latest) (1.0.2)
7. cloudlist (latest) (1.0.2)
8. proxify (latest) (0.0.8)
9. tlsx (latest) (1.0.5)
10. notify (latest) (1.0.4)
11. chaos-client (latest) (0.4.0)
12. shuffledns (latest) (1.0.8)
13. mapcidr (latest) (1.0.3)
14. interactsh-server (latest) (1.0.7)
15. interactsh-client (latest) (1.0.7)
16. katana (latest) (0.0.3)
17. pdtm (latest) (0.0.3)
$ ./pdtm -ua

[INF] subfinder: already up to date
[INF] dnsx: already up to date
[INF] naabu: not found
[INF] httpx: already up to date
[INF] nuclei: already up to date
[INF] uncover: already up to date
[INF] cloudlist: already up to date
[INF] proxify: already up to date
[INF] updating tlsx...
[INF] updated tlsx to 1.0.5(latest)
[INF] notify: already up to date
[INF] chaos-client: already up to date
[INF] shuffledns: already up to date
[INF] mapcidr: already up to date
[INF] interactsh-server: already up to date
[INF] interactsh-client: already up to date
[INF] updating katana...
[INF] updated katana to 0.0.3(latest)
[INF] pdtm: already up to date

@Mzack9999
Copy link
Member Author

@ehsandeep I think the root cause is related to #52 - No tool out of the provided path should be deleted/updated

@ehsandeep ehsandeep merged commit 46c7d3b into dev Jan 31, 2023
@ehsandeep ehsandeep deleted the issue-35-tool-update branch January 31, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update option should only update outdated projects (not install not found one)
2 participants