Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving version detection + minor changes #135

Merged
merged 6 commits into from
May 18, 2023
Merged

Improving version detection + minor changes #135

merged 6 commits into from
May 18, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 7, 2023 •
edited
Loading

Closes #127

Example:

$ go run .

                ____
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/

                projectdiscovery.io

[INF] Current pdtm version v0.0.6 (latest)
[INF] [OS: WINDOWS] [ARCH: AMD64] [GO: 1.20.4]
[INF] Path to download project binary: C:\Users\user\.pdtm\go\bin
[INF] Path C:\Users\user\.pdtm\go\bin configured in environment variable $PATH
1. aix (latest) (0.0.2)
2. subfinder (outdated) (2.5.6) ➡ (2.5.8)
3. dnsx (outdated) (1.1.2) ➡ (1.1.4)
4. naabu (latest) (2.1.6)
5. httpx (outdated) (1.2.7) ➡ (1.3.0)
6. nuclei (latest) (2.9.3)
7. uncover (outdated) (1.0.2) ➡ (1.0.4)
8. cloudlist (outdated) (1.0.2) ➡ (1.0.3)
9. proxify (outdated) (0.0.8) ➡ (0.0.9)
10. tlsx (outdated) (1.0.5) ➡ (1.0.9)
11. notify (latest) (1.0.4)
12. chaos-client (outdated) (0.4.0) ➡ (0.5.1)
13. shuffledns (outdated) (1.0.8) ➡ (1.0.9)
14. mapcidr (outdated) (1.1.0) ➡ (1.1.1)
15. interactsh-client (outdated) (1.1.0) ➡ (1.1.3)
16. interactsh-server (latest) (1.1.3)
17. katana (outdated) (0.0.3) ➡ (1.0.1)
18. pdtm (latest) (0.0.6)
19. asnmap (latest) (1.0.3)
20. alterx (latest) (0.0.1)
21. cdncheck (latest) (1.0.0)
22. simplehttpserver (latest) (0.0.6)

@Mzack9999 Mzack9999 self-assigned this May 7, 2023
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 7, 2023
@Mzack9999 Mzack9999 linked an issue May 7, 2023 that may be closed by this pull request
version number is not displayed for nuclei #127
Closed
@Mzack9999 Mzack9999 marked this pull request as ready for review May 7, 2023 21:32
ehsandeep
ehsandeep reviewed May 15, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

which nuclei
/Users/geekboy/.pdtm/go/bin/nuclei
./pdtm

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

		projectdiscovery.io

[INF] Current pdtm version v0.0.6 (latest)
[INF] [OS: DARWIN] [ARCH: AMD64] [GO: 1.20.2]
[INF] Path to download project binary: /Users/geekboy/.pdtm/go/bin
[INF] Path /Users/geekboy/.pdtm/go/bin configured in environment variable $PATH
1. aix (latest) (0.0.2)
2. subfinder (latest) (2.5.8)
3. dnsx (latest) (1.1.4)
4. naabu (latest) (2.1.6)
5. httpx (latest) (1.3.1)
6. nuclei (latest) (2.9.4)
7. uncover (latest) (1.0.4)
8. cloudlist (latest) (1.0.3)
9. proxify (latest) (0.0.9)
10. tlsx (latest) (1.0.9)
11. notify (latest) (1.0.4)
12. chaos-client (latest) (0.5.1)
13. shuffledns (latest) (1.0.9)
14. mapcidr (latest) (1.1.1)
15. interactsh-client (latest) (1.1.3)
16. interactsh-server (latest) (1.1.3)
17. katana (latest) (1.0.1)
18. pdtm (latest) (0.0.6)
19. asnmap (latest) (1.0.4)
20. alterx (latest) (0.0.1)
21. cdncheck (latest) (1.0.3)
22. simplehttpserver (latest) (0.0.6)
pdtm $./pdtm -ua

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

		projectdiscovery.io

[INF] Current pdtm version v0.0.6 (latest)
[INF] aix: already up to date
[INF] subfinder: already up to date
[INF] dnsx: already up to date
[INF] naabu: already up to date
[INF] httpx: already up to date
[INF] updating nuclei...
[INF] updated nuclei to 2.9.4 (latest)
[INF] uncover: already up to date
[INF] cloudlist: already up to date
[INF] proxify: already up to date
[INF] tlsx: already up to date
[INF] notify: already up to date
[INF] chaos-client: already up to date
[INF] shuffledns: already up to date
[INF] mapcidr: already up to date
[INF] interactsh-client: already up to date
[INF] interactsh-server: already up to date
[INF] katana: already up to date
[INF] pdtm: already up to date
[INF] asnmap: already up to date
[INF] alterx: already up to date
[INF] cdncheck: already up to date
[INF] simplehttpserver: already up to date

I can confirm the version display bug is fixed, but it's unclear why nuclei is being updated even it is on the latest version.

@Mzack9999 Mzack9999 requested a review from ehsandeep May 16, 2023 17:52
@ShubhamRasal
solve nuclei updating everytime
cf7cb2a 
- pdtm-api for nuclei also include the nuclei-templates data
- have to handle it different way than other tools
- add the os, arch, go version in fetchTool api
@ShubhamRasal ShubhamRasal mentioned this pull request May 18, 2023
Merged
tarunKoyalwar
tarunKoyalwar approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

$ ./pdtm 

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

		projectdiscovery.io

[INF] Current pdtm version v0.0.6 (latest)
[INF] [OS: DARWIN] [ARCH: ARM64] [GO: 1.20.4]
[INF] Path to download project binary: /Users/tarun/.pdtm/go/bin
[INF] Path /Users/tarun/.pdtm/go/bin configured in environment variable $PATH
1. aix (not installed)
2. subfinder (latest) (2.5.8)
3. dnsx (latest) (1.1.4)
4. naabu (latest) (2.1.6)
5. httpx (not installed)
6. nuclei (latest) (2.9.4)
7. uncover (latest) (1.0.4)
8. cloudlist (latest) (1.0.3)
9. proxify (latest) (0.0.9)
10. tlsx (latest) (1.0.9)
11. notify (latest) (1.0.4)
12. chaos-client (latest) (0.5.1)
13. shuffledns (latest) (1.0.9)
14. mapcidr (latest) (1.1.2)
15. interactsh-client (latest) (1.1.3)
16. interactsh-server (latest) (1.1.3)
17. katana (latest) (1.0.1)
18. pdtm (latest) (0.0.6)
19. asnmap (latest) (1.0.4)
20. alterx (latest) (0.0.1)
21. cdncheck (not installed)
22. simplehttpserver (latest) (0.0.6)

@ehsandeep ehsandeep merged commit 63b49f2 into dev May 18, 2023
@ehsandeep ehsandeep deleted the issue-127-nuclei-version branch May 18, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version number is not displayed for nuclei
4 participants
@Mzack9999 @ehsandeep @tarunKoyalwar @ShubhamRasal