print requirement info #166
Conversation
There was a problem hiding this comment.
It seems like there is some issue with deps detection on osx:
$ ./pdtm -i naabu
____
____ ____/ / /_____ ___
/ __ \/ __ / __/ __ __ \
/ /_/ / /_/ / /_/ / / / / /
/ .___/\__,_/\__/_/ /_/ /_/
/_/
projectdiscovery.io
[INF] Current pdtm version v0.0.7 (latest)
[INF] Run `source ~/.bashrc` to add /Users/marcornvh/.pdtm/go/bin to $PATH
[INF] installing naabu...
[INF] installed naabu 2.1.6 (latest)
[INF] naabu requirements:
required To install libpcap on macOS, run the following command in the terminal: sudo brew install libpcap
$ brew install libpcap
Warning: libpcap 1.10.4 is already installed and up-to-date.
We can try a more straightforward strategy, like executing the binary just downloaded and checking the output for errors, then suggesting how to install deps. What do you think?
@Mzack9999, the problem may be linked to how the OS names files. For further details, please refer to https://github.com/projectdiscovery/utils/blob/main/syscallutil/syscallutil_test.go#L15. Your suggestion appears more practical, we can proceed with it. However, before implementing any changes, it's worth noting that our tools may not check for dependencies when run without any flag. While a health check might work, not all tools have this functionality. Any suggestion? |
|
@dogancanbakir I think we can improve the multi-platform check and make it more precise with additional steps (like running the tool and seeing if any error gets printed to stdout/stderr - as previously mentioned. I changed red to yellow for now since the missing dependency might prevent the tool from running under certain conditions but not being installed as we are downloading the binary directly. |
This PR prints tool requirement info for given tools. Closes #6.