This repository has been archived by the owner on Jul 3, 2021. It is now read-only.
[Feature] Added disabled state & controlled state in Android #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying the "selection" prop now launches an animation of shape Setting the "disable" prop now stops the onClickListener from firing
|
Thanks @jvdsande for the effort and PR. I have resolved conflict and merge the same. I have also made the same implementation changes for iOS. Post testing I will push the release. Thanks |
|
Hi @prscX, Sorry I have not been working on the project using your product for a while now. I've had the occasion to test it today, it works like expected! Regards, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the "selection" prop now launches an animation of shape
Setting the "disable" prop now stops the onClickListener from firing