Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include --unstable in cache key #4466

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Include --unstable in cache key #4466

merged 4 commits into from
Sep 27, 2024

Conversation

JelleZijlstra
Copy link
Collaborator

Fixes #4465

@JelleZijlstra JelleZijlstra mentioned this pull request Sep 27, 2024
Closed
@JelleZijlstra
Copy link
Collaborator Author

There's something wrong on the 3.13 CI for macOS, investigating.

hauntsaninja
hauntsaninja approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, useful test

@hauntsaninja hauntsaninja merged commit f1a2f92 into psf:main Sep 27, 2024
46 checks passed
@hauntsaninja
Copy link
Collaborator

I wonder how many random issues incremental GC is going to turn up

@JelleZijlstra JelleZijlstra deleted the fixcache2 branch September 27, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache causes confusing behavior when running with and without "--unstable"
2 participants
@JelleZijlstra @hauntsaninja