Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.18] Fix PyGObject requirements and deps #3693

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

pedro-psb
Copy link
Member

I was working on a fix for 3.18 failures but got stuck with wrong response code errors (here). As this error doesnt seem related to the pygobject one, I'll submit that separately here, so we have some progress.

[noissue]

@@ -4,6 +4,6 @@ jsonschema>=4.6,<5.0
libcomps>=0.1.20.post1,<0.2
productmd~=1.33.0
pulpcore>=3.17,<3.25
PyGObject>=3.40,<3.46
PyGObject>=3.40,<3.45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we do not install pygobject with pip (i can only assume it's preinstalled from rpm).
And any upper bound whatsoever will conflict with the upper bounds constraints.
At this point i think we need to exempt this library from the bounds calculator altogether. This also sadly means we never test any version other than the one provided in the image.

@ggainey ggainey changed the title Fix PyGObject requirements and deps [3.18] Fix PyGObject requirements and deps Jul 24, 2024
@github-actions github-actions bot added the multi-commit Added when a PR consists of more than one commit label Jul 24, 2024
@pedro-psb
Copy link
Member Author

@ggainey I've manually applied the latest plugin-template so we can see that the pygobject errors are gone.

Now we are left with the "403 instead of 405 error", but I dont see any evidence that these two are correlated.
Can we merge this so we can work out the 405 independently?

Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one failing test needs investigation - but it doesn't appear to be caused by the changes happening here to get us building again in this (suported) channel. Approving, so we can get a little further, and separate the two issues.

@ggainey ggainey merged commit 7302950 into pulp:3.18 Jul 24, 2024
11 of 16 checks passed
@pedro-psb pedro-psb deleted the fix/pygobject-deps-on-3.18-branch branch July 24, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-commit Added when a PR consists of more than one commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants