[3.19] Wrong advisory count investigation

[pedro-psb]

This PR is for sharing some observations on the problem of wrong number of advisories count on branch 3.19:

Error

        # Test content visibility
        # TODO: modules
        with user_creator:
            _assert_listed_content()
    
        with user_viewer:
>           _assert_listed_content()

usr/local/lib/python3.8/site-packages/pulp_rpm/tests/functional/api/test_rbac_crud.py:517: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    def _assert_listed_content():
        packages_count = rpm_package_api.list(repository_version=repo.latest_version_href).count
        assert RPM_FIXTURE_SUMMARY["rpm.package"] == packages_count
    
        advisories_count = rpm_advisory_api.list(repository_version=repo.latest_version_href).count
>       assert RPM_FIXTURE_SUMMARY["rpm.advisory"] == advisories_count
E       assert 4 == 20

usr/local/lib/python3.8/site-packages/pulp_rpm/tests/functional/api/test_rbac_crud.py:494: AssertionError

Observations

• Basic failure setup:
  • run only test_rbac_content_scoping + one of other test that sync from the same fixture (apparently). E.g test_rbac_dsitribution.
  • run them in parallel with any number of workers.
• Locally, something like: oci-env test -p pulp_rpm functional -n 8 -vk test_rbac_crud
• Only happens under user_viewer context
• Reverting the last obvious advisory-related commits didnt make any difference. They are:

  8d6dc66b Fix a flaw that allowing duplicate advisories in repo version  # 11 June 2024
  3158fd0b Addressed an edge-case around advisory-collection name collisions.  # 25 Jan 2024

• Looks related to the problem presented here: Return distinct content units from the queryset scope filtering pulpcore#3642

[pedro-psb]

Backporting pulp/pulpcore#3642 to 3.21 and 3.22 should hopefully fix this.