Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdist_wheel should be able to work with pre-computed dist-info, per PEP-517 #611

Closed
pelson opened this issue Apr 24, 2024 · 2 comments
Closed

Comments

@pelson
Copy link

pelson commented Apr 24, 2024

As discussed at pypa/setuptools#1825, PEP-517 states that a wheel building backend should be able to accept an existing dist-info directory.

If the build frontend has previously called prepare_metadata_for_build_wheel and depends on the wheel resulting from this call to have metadata matching this earlier call, then it should provide the path to the created .dist-info directory as the metadata_directory argument. If this argument is provided, then build_wheel MUST produce a wheel with identical metadata. The directory passed in by the build frontend MUST be identical to the directory created by prepare_metadata_for_build_wheel, including any unrecognized files it created.

Currently, bdist_wheel does not make this possible. Would it be possible to add a dist-info-dir or equivalent argument to bdist_wheel?

pelson added a commit to pelson/wheel that referenced this issue Apr 24, 2024
…handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes pypa#611
pelson added a commit to pelson/wheel that referenced this issue Apr 24, 2024
…handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes pypa#611
pelson added a commit to pelson/wheel that referenced this issue Apr 24, 2024
…handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes pypa#611
pelson added a commit to pelson/wheel that referenced this issue Apr 24, 2024
…handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes pypa#611
pelson added a commit to pelson/wheel that referenced this issue Apr 24, 2024
…handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes pypa#611
@agronholm
Copy link
Contributor

I'm closing this, as the canonical location for bdist_wheel is now in setuptools.

@agronholm agronholm closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@pelson
Copy link
Author

pelson commented May 24, 2024

Thanks for following-up, and congrats on tightening the scope of the project 👍.
I'll follow-up on setuptools (no doubt with a x-link for future readers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants