Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "Refactoring multiple parts of the dockerfile (#10004)" #10021

Closed
wants to merge 1 commit into from

Conversation

ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Sep 8, 2021

Reverts #10020

@ewdurbin
Copy link
Member Author

ewdurbin commented Sep 8, 2021

HOLD FOR: upgrade to BuildKit compatible builders in deployment pipeline.

@miketheman
Copy link
Member

The underlying code has changed a fair amount since this was introduced and no longer merged cleanly.

I think there's still good ideas on leveraging cache mounts, but they rely on BuildKit being available during deployment. @ewdurbin is this something we still want to entertain?

@ewdurbin
Copy link
Member Author

ewdurbin commented Jan 9, 2023

absolutely want to entertain this. getting us up to a more recent container runtime that supports buildkit is a priority in the coming months.

@miketheman miketheman added the blocked Issues we can't or shouldn't get to yet label Jan 10, 2023
@ewdurbin
Copy link
Member Author

I thought it was just the docker service that needed BuildKit, but turns out its the client too.

Cabotage interacts with the docker build hosts via docker-py which notably does not support BuildKit. ref docker/docker-py#2230

So this remains blocked even after getting our builder upgraded 😅

@ewdurbin
Copy link
Member Author

We have a buildkit enabled deployment pipeline! I am closing this in favor of a new implementation to avoid all the deltas that have been introduced.

@ewdurbin ewdurbin closed this Jul 17, 2023
@ewdurbin ewdurbin deleted the revert-10020-revert/10004 branch August 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues we can't or shouldn't get to yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants