Clarify that capfdbinary captures on a filedescriptor level.
#12840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The opening clause was the same for this paragraph and the previous paragraph, making it seem like they were duplicates. I added some text making it clearer that this paragraph is about filedescriptors.
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
|
Thanks @pradeep90! Took the liberty of rebasing this on Also improved the overall text by adding links and reordering the text. |
nicoddemus
added
the
skip news
nicoddemus
approved these changes
Sep 25, 2024
nicoddemus
added
the
backport 8.3.x
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #12841 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Improve the section by reordering how the topics about text/binary capture are presented, and add proper links to the fixtures. Co-authored-by: Bruno Oliveira <bruno@soliv.dev> (cherry picked from commit 326faa2)
nicoddemus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Improve the section by reordering how the topics about text/binary capture are presented, and add proper links to the fixtures. Co-authored-by: Bruno Oliveira <bruno@soliv.dev> (cherry picked from commit 326faa2) Co-authored-by: Pradeep Kumar <gohanpra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paragraph and the previous paragraph had the same opening clause, making it seem like they were duplicates. I added some text making it clearer that this paragraph is about filedescriptors.