testing: use a tighter check if bash is available
#7520
Conversation
This fixes CI on Windows since GitHub Actions started installing WSL on their images which apparently installs some wrapper `bash` which does not run actual bash.
|
The diff looks good, but I'm a bit confused about the CI output now: that looks like those tests are actually passing now, rather than being skipped? 🤔 |
|
The skip in |
| ["bash", "--version"], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, | ||
| universal_newlines=True, |
| bash_version = subprocess.run( | ||
| ["bash", "--version"], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, |
There was a problem hiding this comment.
you only look at the .stdout, so I think it's cleaner with stderr=subprocess.DEVNULL ?
|
Sorry for the fast merge, I thought it'd be good to unblock the CI before more people start running into issues with their PRs. I'd be happy to review a follow-up PR (and also wait a bit before merging there) - agreed with |
|
No worries, I only got the email notification when the merge happened. |
Fixes #7518.
This fixes CI on Windows since GitHub Actions started installing WSL on their images which apparently installs some wrapper
bashwhich does not run actual bash.